Statically link mingw/msvc runtime libraries on Windows #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
dsnopek
force-pushed
the
1082-update
branch
2 times, most recently
from
1789aae to
54515da
Compare
bruvzg
reviewed
Aug 8, 2023
Co-authored-by: David Snopek <dsnopek@gmail.com>
|
Alright, I've tested this with MSVC and it seems to be working! So, I'm taking it out of "draft" now :-) |
akien-mga
reviewed
Aug 9, 2023
| else: | ||
| env.Append(CCFLAGS=["/MD"]) | ||
| elif env["optimize"] == "debug" or env["optimize"] == "none": | ||
| env.Append(CCFLAGS=["/Od"]) | ||
|
|
||
| else: | ||
| if env["debug_symbols"]: |
There was a problem hiding this comment.
Another potential sync with Godot, to add here:
# Adding dwarf-4 explicitly makes stacktraces work with clang builds,
# otherwise addr2line doesn't understand them
env.Append(CCFLAGS=["-gdwarf-4"])
But that can also go in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #1082, implementing the requested review, and removing some changes that seem unrelated to the goal of the PR.
This is still a draft because I haven't yet had a chance to try the MSVC-related changes. However, this is working in my testing with mingw.
Thanks to @feiyunw for making the original PR!
Fixes #1064
Fixes #976